keyop-go/nfq_forwarder
1
0
Fork 0
Code Issues 11 Pull requests Projects Releases 13 Packages Wiki Activity Actions

Possible edit race condition? #30

New issue
Closed
opened 2026-07-07 13:26:02 +01:00 by danny · 7 comments
danny commented 2026-07-07 13:26:02 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

It looks to me like there may be a possible race condition if two browser sessions have the 'edit' view open at the same time and attempt to make changes. Investigate this and find a way to resolve it if this turns out to be a valid concern.

It looks to me like there may be a possible race condition if two browser sessions have the 'edit' view open at the same time and attempt to make changes. Investigate this and find a way to resolve it if this turns out to be a valid concern.
danny commented 2026-07-07 13:26:52 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

changed the description

changed the description
claude commented 2026-07-07 21:22:28 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

mentioned in merge request !73

mentioned in merge request !73
claude commented 2026-07-08 06:40:27 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

mentioned in commit 8df131d454

mentioned in commit 8df131d454a54ea86d01fec8793b21e1d0e8aef8
claude commented 2026-07-08 06:40:48 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

mentioned in merge request !75

mentioned in merge request !75
claude commented 2026-07-08 06:40:57 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

Confirmed this is a real race condition (a classic lost-update: two sessions loading the same config, second save silently overwrites the first with no warning). Implementation up for review: !75 (branch issue30_config_edit_race_condition) - adds optimistic concurrency control (a content hash issued on read, required back on save, rejected with 409 if the file changed underneath). See the MR description for full detail.

Confirmed this is a real race condition (a classic lost-update: two sessions loading the same config, second save silently overwrites the first with no warning). Implementation up for review: !75 (branch `issue30_config_edit_race_condition`) - adds optimistic concurrency control (a content hash issued on read, required back on save, rejected with 409 if the file changed underneath). See the MR description for full detail.
danny commented 2026-07-08 06:51:23 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

mentioned in commit b09470ea60

mentioned in commit b09470ea605917d5a71c41f94d54727406f94824
danny (Migrated from gitlab.keyop.co.uk) closed this issue 2026-07-08 06:51:23 +01:00
claude commented 2026-07-08 06:52:30 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

Merged via !75 (merge commit b09470e) and released as v1.1.5 (patch bump).

Merged via !75 (merge commit `b09470e`) and released as **v1.1.5** (patch bump).
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v1.1.5
v1.1.4
v1.1.3
v1.1.2
v1.1.1
v1.1.0
v1.0.6
v1.0.5
v1.0.4
v1.0.3
v1.0.2
v1.0.1
v1.0.0
Labels
Clear labels   
Bug

   
BuildIssue

   
Claude-fixed

   
Enhancement

   
In Progress

   
Low priority

   
On Hold
Blocked on something outside this project (e.g. external infrastructure) - not actionable right now

  
Security
No labels
Bug
BuildIssue
Claude-fixed
Enhancement
In Progress
Low priority
On Hold
Security
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
keyop-go/nfq_forwarder#30
No description provided.