keyop-go/nfq_forwarder
1
0
Fork 0
Code Issues 11 Pull requests Projects Releases 13 Packages Wiki Activity Actions

issue#6 - Use go native SSH #46

Merged
danny merged 4 commits from issue#6_go_native_ssh into main 2024-07-15 14:10:03 +01:00
Conversation 12 Commits 4 Files changed 7 +372 -96
danny commented 2024-07-14 21:47:47 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

This covers the body of the implementation, but there are stil areas to address around the configuration (too many hard-coded values still).

When finished, will resolve https://gitlab.keyop.co.uk/keyop/go/nfq_forwarder/-/issues/6

This covers the body of the implementation, but there are stil areas to address around the configuration (too many hard-coded values still). When finished, will resolve https://gitlab.keyop.co.uk/keyop/go/nfq_forwarder/-/issues/6
danny (Migrated from gitlab.keyop.co.uk) approved these changes 2024-07-14 21:47:47 +01:00
danny commented 2024-07-14 21:47:48 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

requested review from @danny

requested review from @danny
danny commented 2024-07-14 21:47:48 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

assigned to @danny

assigned to @danny
danny commented 2024-07-15 06:46:26 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>3549e3f3 - Clean up error handling</li></ul> [Compare with previous version](/keyop/go/nfq_forwarder/-/merge_requests/5/diffs?diff_id=75&start_sha=2989f10355abb3b36b3076960f238d63aa5274ee)
danny commented 2024-07-15 14:03:05 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

added 1 commit

  • 134c042a - Add profiling, remove some extraneous debug

Compare with previous version

added 1 commit <ul><li>134c042a - Add profiling, remove some extraneous debug</li></ul> [Compare with previous version](/keyop/go/nfq_forwarder/-/merge_requests/5/diffs?diff_id=77&start_sha=3549e3f3b3a2e3c8a384165c7a4ad1c46a027bec)
danny commented 2024-07-15 14:04:48 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

mentioned in issue #4

mentioned in issue #4
danny commented 2024-07-15 14:08:44 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

marked this merge request as ready

marked this merge request as **ready**
danny commented 2024-07-15 14:09:41 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

Hardcoded values will stay for now and be handled in https://gitlab.keyop.co.uk/keyop/go/nfq_forwarder/-/issues/3. Basic scope of this ticket is covered.

Hardcoded values will stay for now and be handled in https://gitlab.keyop.co.uk/keyop/go/nfq_forwarder/-/issues/3. Basic scope of this ticket is covered.
danny commented 2024-07-15 14:09:56 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

approved this merge request

approved this merge request
danny commented 2024-07-15 14:10:03 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

mentioned in commit 43a694165d

mentioned in commit 43a694165d63d15451a4fa39b1b21dce00a1ea10
danny (Migrated from gitlab.keyop.co.uk) merged commit 43a694165d into main 2024-07-15 14:10:03 +01:00
danny commented 2024-07-15 14:11:46 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

mentioned in issue #3

mentioned in issue #3
danny commented 2024-07-16 15:42:32 +01:00 (Migrated from gitlab.keyop.co.uk)
Copy link

mentioned in merge request !47

mentioned in merge request !47
Sign in to join this conversation.
Reviewers
No reviewers
danny
Labels
Clear labels   
Bug

   
BuildIssue

   
Claude-fixed

   
Enhancement

   
In Progress

   
Low priority

   
On Hold
Blocked on something outside this project (e.g. external infrastructure) - not actionable right now

  
Security
No labels
Bug
BuildIssue
Claude-fixed
Enhancement
In Progress
Low priority
On Hold
Security
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
keyop-go/nfq_forwarder!46
No description provided.