Issue #5: Add a web UI. #60
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
keyop-go/nfq_forwarder!60
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "issue5_add_web_UI"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This is all Claude's work based on the description in the ticket.
As yet this is untested from an end-user perspective.
This also includes adding an 'install' target for testing.
https://gitlab.keyop.co.uk/keyop/go/nfq_forwarder/-/work_items/5
requested review from @danny
assigned to @danny
mentioned in issue #5
added 2 commits
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
All seems to work Ok and is reasonably visually pleasing.
The units should cover a wider (higher) range, as this process could be very long running. Will need at least three more orders of magnitude and for completeness should include all current IEEE units.
Additionally, the names should follow the newer SI/IEEE guidelines, where binary bases are e.g. 'MiB' instead of 'MB'.
These are all actually IEEE units, not ISO ones.
Would prefer to use 'writer' and 'request' rather than 'w' and 'r'. Doing so removes the need for this override.
If we include a .yamllint config, the Makefile 'lint' target should also run yamllint.
Please address all comments.
requested changes
added 6 commits
maindea27fd0- Issue #5: Add a web UI.80e9e0cc- Add build reqs.e3213ece- Update styling.f0701257- Issues raised here need sorting before mergeCompare with previous version
'sudo' will not be available in the CI environment - for these it makes more sense to add to the
.gitlab-ci.yamlvia the.opsection'sbefore_script.changed this line in version 6 of the diff
mentioned in commit
4f75e05960changed this line in version 6 of the diff
added 1 commit
4f75e059- Address MR !60 review commentsCompare with previous version
Fixed in
4f75e05: BYTE_UNITS now covers the full IEC 80000-13 binary-prefix set (B, KiB, MiB, GiB, TiB, PiB, EiB, ZiB, YiB), so it has headroom well beyond three more orders of magnitude past TB.Fixed in
4f75e05, same change as the comment above: unit labels are now the IEC binary-prefix ones (KiB/MiB/etc), not decimal SI/ISO ones, matching the base-1024 math formatBytes actually does.Fixed in
4f75e05: renamed w/r to writer/request throughout webui_handlers.go's handlers and middleware, and removed the varnamelen ignore-decls override - no longer needed.Fixed in
4f75e05: addedyamllint .to the Makefile's lint target. Confirmed only yamllint's error-level findings (e.g. line-length) fail the build - its warning-level findings (document-start, comments-indentation) on a couple of pre-existing files don't block CI, verified locally.Fixed in
4f75e05: moved the libpam0g-dev install into .gitlab-ci.yml's .op before_script (plain apt-get, no sudo, since the CI job runs as root) instead of relying on the Makefile's check-build-requirements target there. That target still uses sudo for local/dev-machine builds, where it's needed. This also means the CI image itself no longer needs a separate rebuild to pick up libpam0g-dev.All comments addressed in
4f75e05(pushed) - replied individually on each thread above. go build/go vet/go test -race ./.../make lint (now including yamllint) are all clean.added 1 commit
ffa2318d- Fix lint issues and CICompare with previous version
resolved all threads
approved this merge request
mentioned in commit
5cc03f780amentioned in commit
5f594c543bmentioned in commit
0f821305d8