Clarify NfQueue (config field) vs NfQeueue (verdict constant) #74

Merged

claude merged 1 commit from issue41_clarify_nfqueue_vs_nfqeueue into main

2026-07-08 06:27:10 +01:00

claude commented

2026-07-08 06:07:48 +01:00

(Migrated from gitlab.keyop.co.uk)

Closes #41

Background

Investigated (with results posted to #41 and MR !73) whether NfQeueue was a Claude-introduced typo. It isn't: github.com/florianl/go-nfqueue@v1.3.2 genuinely exports its verdict constant misspelled as NfQeueue (confirmed directly from the vendored module source, types.go). The same package separately exports a correctly spelled, unrelated identifier - Config.NfQueue (a uint16 struct field for which queue number to bind to) - used once in this codebase's initNfqueue. A full repo grep for both spellings found every usage of each already correct for what it refers to.

Change

Purely a clarifying comment at the one NfQueue (config field) usage, explaining it's a different identifier from the verdict constant NfQeueue used elsewhere in the file, so this doesn't get mistaken for an inconsistency again.

Testing

Documentation-only change - make lint/make test both clean, no behavior change.

Follow-up to #33 (MR !73, now merged) - the doc comment this one cross-references (on setVerdict, explaining the NfQeueue landmine) landed there.

Closes #41 ## Background Investigated (with results posted to #41 and MR !73) whether `NfQeueue` was a Claude-introduced typo. It isn't: `github.com/florianl/go-nfqueue@v1.3.2` genuinely exports its verdict constant misspelled as `NfQeueue` (confirmed directly from the vendored module source, `types.go`). The same package separately exports a *correctly* spelled, unrelated identifier - `Config.NfQueue` (a `uint16` struct field for which queue number to bind to) - used once in this codebase's `initNfqueue`. A full repo grep for both spellings found every usage of each already correct for what it refers to. ## Change Purely a clarifying comment at the one `NfQueue` (config field) usage, explaining it's a different identifier from the verdict constant `NfQeueue` used elsewhere in the file, so this doesn't get mistaken for an inconsistency again. ## Testing Documentation-only change - `make lint`/`make test` both clean, no behavior change. ## Related Follow-up to #33 (MR !73, now merged) - the doc comment this one cross-references (on `setVerdict`, explaining the `NfQeueue` landmine) landed there.

danny (Migrated from gitlab.keyop.co.uk) approved these changes

2026-07-08 06:07:48 +01:00

claude commented

2026-07-08 06:08:00 +01:00

(Migrated from gitlab.keyop.co.uk)

mentioned in issue #41

claude commented

2026-07-08 06:09:50 +01:00

(Migrated from gitlab.keyop.co.uk)

added 3 commits

893bb8b7...acda1b5b - 2 commits from branch main
3d67c563 - Clarify NfQueue (config field) vs NfQeueue (verdict constant) (#41)

Compare with previous version

added 3 commits <ul><li>893bb8b7...acda1b5b - 2 commits from branch <code>main</code></li><li>3d67c563 - Clarify NfQueue (config field) vs NfQeueue (verdict constant) (#41)</li></ul> [Compare with previous version](/keyop/go/nfq_forwarder/-/merge_requests/33/diffs?diff_id=334&start_sha=893bb8b79046f7cbf8db8e147112a4a28beb5fbb)

danny commented

2026-07-08 06:10:08 +01:00

(Migrated from gitlab.keyop.co.uk)

assigned to @claude